Detonate Ivan Bombs placed by the attacker using custom warhead. by dh381-1 · Pull Request #2365 · Phobos-developers/Phobos

dh381-1 · 2026-08-23T06:13:31Z

What kind of change is this?

New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

Now you can detonate planted Ivan bombs using custom warhead. The bomb attached to the targeted unit will explode immediately, provided that it was planted by the attacker.
Use IvanBomb.Detonate.InvokerOnly to configure whether the warhead can detonate Ivan bombs from other sources.
Use IvanBomb.Detonate.AffectsType to configure which targets' Ivan bombs can be detonated by warhead, use empty for all types.

In rulesmd.ini:

[SOMEWARHEAD]                             ; WarheadType
IvanBomb.Detonate=true                    ; boolean
IvanBomb.Detonate.InvokerOnly=false       ; boolean
IvanBomb.Detonate.AffectsType=HTNK,E1     ; List of Registration Name, use empty list for all types

phoboscn-bot · 2026-08-23T06:18:37Z

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/725/14

phoboscn-bot · 2026-08-23T06:56:51Z

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/739/1

NetsuNegi · 2026-08-23T11:51:57Z

+
+DEFINE_HOOK(0x702D19, TechnoClass_ReceiveDamage_IvanBombDetonate, 0x6)
+{
+	GET(ObjectClass*, pThis, ESI);                   


pThis should be TechnoClass*. Besides, register esi has been popped here, I think you should not use it.
pThis 应该是 TechnoClass*。另外，ESI寄存器在此处已被弹出，我认为你不该用它。

After changing the hook location,register esi can be used
换了一个hook位置，ESI寄存器现在就可以用了

github-actions · 2026-08-23T14:53:35Z

Nightly build for this pull request:

compiled-dll-36c81132ef4e2ccaf852fa9fa6428c051ce049f9.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

DeathFishAtEase · 2026-08-24T08:15:17Z

+In `rulesmd.ini`:
+```ini
+[SOMEWEAPON]               ; WeaponType
+IvanBomb.Detonate=true     ; Enable bomb detonation (true/false), default: false.


Suggested change

IvanBomb.Detonate=true ; Enable bomb detonation (true/false), default: false.

IvanBomb.Detonate=false ; boolean

If there is a fixed default value, it should be placed as the value on the right side of the equals sign; only the value type should be written after the semicolon.

NetsuNegi · 2026-08-24T11:12:56Z

 	bool SkipWeaponPicking;

 	Nullable<bool> CylinderRangefinding;
+


what's this ?

NetsuNegi · 2026-08-24T11:14:23Z

Other codes looking good

Coronia

I think this doesn't have to be restricted to the owner's bomb. It would also be useful if another unit could detonate it. Something like this:

IvanBomb.Detonate.InvokerOnly -> whether it can only affect your own bomb or not
IvanBomb.Detonate.AffectsType -> TechnoTypes in this list can have their ivan bomb detonated by this warhead. Use empty list for all types

NetsuNegi · 2026-08-25T12:55:08Z

+
+	if(auto pBomb = pThis->AttachedBomb)
+	{
+		if(auto pSourceExt = TechnoExt::Fetch(pSource))


this sanity check is not nesseary

NetsuNegi · 2026-08-25T12:57:27Z

+				if(!pWHExt->IvanBomb_Detonate)
+					return 0;
+
+				bool CanAffects = pWHExt->IvanBomb_Detonate_AffectsType.Contains(pThis->GetTechnoType()) 


I think it will be better to check empty first

TaranDahl · 2026-08-25T15:43:24Z

+[SOMEWARHEAD]                             ; WarheadType
+IvanBomb.Detonate=true                    ; boolean
+IvanBomb.Detonate.InvokerOnly=false       ; boolean
+IvanBomb.Detonate.AffectsType=HTNK,E1     ; List of Registration Name, use empty list for all types


It is unreasonable to reinvent a filter here.

TaranDahl · 2026-08-25T15:46:56Z

 	return ContinueCheck;
 }
+
+DEFINE_HOOK(0x701DFF, TechnoClass_ReceiveDamage_IvanBombDetonate, 0x7)


This hook is redundant.
You should process this in WarheadTypeExt::DetonateOnOneUnit.

TaranDahl · 2026-08-25T15:49:10Z

+				if(pWHExt->IvanBomb_Detonate_InvokerOnly)
+				{
+					if(pBomb->Owner == pSource && CanAffects)
+						pBomb->Detonate();


Invoking a damage in another damage process is dangerous.
IMO resetting the timer would be better.

dh381-1 added 6 commits August 23, 2026 11:48

Merge upstream/develop and resolve conflicts

4fb6212

add IvanBomb.Detonate gif

9b78f6e

add IvanBomb.Detonate

a7a4f38

Update New-or-Enhanced-Logics.md

6ca4890

Update Body.h

c32e59d

Update CREDITS.md

1f7c416

dh381-1 added 3 commits August 23, 2026 18:12

1

0465718

update Hooks.WeaponEfects.cpp

a3af3cf

update Hooks.WeaponEffects.cpp

2ce9c38

NetsuNegi reviewed Aug 23, 2026

View reviewed changes

update Hooks.WeaponEffect.cpp

66dbf2e

DeathFishAtEase reviewed Aug 24, 2026

View reviewed changes

fix bug

2744e97

dh381-1 changed the title ~~Detonate Ivan Bombs placed by the attacker using custom weapons.~~ Detonate Ivan Bombs placed by the attacker using custom warhead. Aug 24, 2026

Update New-or-Enhanced-Logics.md

872ee5b

NetsuNegi reviewed Aug 24, 2026

View reviewed changes

NetsuNegi requested changes Aug 24, 2026

View reviewed changes

Comment thread src/Ext/Techno/Hooks.ReceiveDamage.cpp Outdated

Coronia reviewed Aug 24, 2026

View reviewed changes

Comment thread src/Ext/Techno/Hooks.ReceiveDamage.cpp Outdated

dh381-1 added 4 commits August 25, 2026 16:17

add new IvanBomb detonate logic

73e83d9

Merge branch 'develop' of https://github.com/dh381-1/Phobos into develop

167ed8f

Update New-or-Enhanced-Logics.md

95b9353

Update New-or-Enhanced-Logics.md

daf1947

NetsuNegi reviewed Aug 25, 2026

View reviewed changes

TaranDahl requested changes Aug 25, 2026

View reviewed changes

	IvanBomb.Detonate=true ; Enable bomb detonation (true/false), default: false.
	IvanBomb.Detonate=false ; boolean

Uh oh!

Uh oh!

Conversation

dh381-1 commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What kind of change is this?

Description

Uh oh!

phoboscn-bot commented Aug 23, 2026

Uh oh!

phoboscn-bot commented Aug 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NetsuNegi commented Aug 24, 2026

Uh oh!

Coronia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dh381-1 commented Aug 23, 2026 •

edited

Loading